Conversation
danxuliu
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
3d36454 to
e04cf6e
Compare
danxuliu
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
e04cf6e to
d89ff42
Compare
danxuliu
added
3. to review
|
They seem to be failing though |
|
@danxuliu can you rebase and check if everything passes now? |
danxuliu
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
d89ff42 to
d05b6a7
Compare
|
In the rebase the helper functions were updated to the latest server version (so they now take into account the change in how internal shares are created since Nextcloud 31) and it was no longer needed to add one of them ( The tests were run locally several times and they always passed, let's see what CI says 🤞 |
Well, all tests failed 🤷 The problems seem to be that showing the list of possible shares takes more than 4 seconds and... that the session is lost while creating the share so a new one is started, but the following requests fail as being unauthenticated due to the new session not being logged in? I do not have any idea of what is going on 🥲 |
artonge
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
2 times, most recently
from
160d7d3 to
8877ed2
Compare
New filesUtils functions adjusted from cypress/e2e/files_sharing/filesSharingUtils.ts of Nextcloud server at commit 30f3cbf5f8578ef8cb6a77ecd304df83089985f0; note that "shareSettings" is not used, so there is no need to include the hack in "createShare" nor add the "updateShare" function. Besides that the helper functions to copy and move a file now support using as destination a directory that is not a descendant of the current directory (as that requires to first navigate to the Home folder in the file picker, which was not supported before, to then descend to the final destination). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
artonge
force-pushed
the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
from
e1892c1 to
33555a4
Compare
|
I used |
artonge
deleted the
add-e2e-tests-for-copying-and-moving-shared-groupfolders
branch
| createGroup(groupName1) | ||
| .then(() => { | ||
| addUserToGroup(groupName1, setupInfo.user1.userId) | ||
| createGroupFolder(groupFolderName1, groupName1, [PERMISSION_READ, PERMISSION_WRITE, PERMISSION_SHARE, PERMISSION_DELETE]) | ||
| }) | ||
| createGroup(groupName2) | ||
| .then(() => { | ||
| addUserToGroup(groupName2, setupInfo.user2.userId) | ||
| createGroupFolder(groupFolderName2, groupName2, [PERMISSION_READ, PERMISSION_WRITE, PERMISSION_SHARE, PERMISSION_DELETE]) | ||
| }) |
There was a problem hiding this comment.
To be more precise, they are only not deleted at the end of this test group. I'll fix it
3 participants
This pull request adds E2E tests for the issue fixed in nextcloud/server#47847 (some scenarios are fixed by that pull request, other scenarios work fine already but were added for completion).
[skip ci]was used for now until the fix is merged, as otherwise running one of the scenarios would recursively copy the data directory of the Nextcloud server and maybe cause issues in CI.