Conversation
skjnldsv
approved these changes
May 25, 2021
Member
|
/compile amend / |
backportbot-nextcloud
bot
requested review from
LukasReschke,
beardhatcode,
danxuliu and
skjnldsv
The errors that required encodeURIComponent in the past have been mittigated by the following commit on nextcloud viewer. nextcloud/viewer@02e1b1a The code with hasScheme may be removed, viewer now returns a full properly encoded URI thanks to the work done in nextcloud-router fixes #381 Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
backport/384/stable20
branch
from
6bdc13a to
1a0d113
Compare
skjnldsv
approved these changes
May 25, 2021
LukasReschke
approved these changes
May 25, 2021
Contributor
|
I don't know if we must check if #286 is not reintroduced. (I tested it on master, but I don't know what happened since 20) |
Contributor
|
I have checked this patch in a 20.0.10 VM, the issue is not reintroduced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #384