Skip to content

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Feb 9, 2026

No description provided.

@i2h3 i2h3 added this to the 33.0.0 milestone Feb 9, 2026
@i2h3 i2h3 self-assigned this Feb 9, 2026
Copilot AI review requested due to automatic review settings February 9, 2026 15:31
@i2h3 i2h3 added the feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. label Feb 9, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Feb 9, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the File Provider logging stack to capture and (in debug builds) emit source location context (file, function, line) alongside existing structured log details.

Changes:

  • Extended FileProviderLogging.write(...) and FileProviderLogger.{debug,info,error,fault} to thread through file/function/line.
  • Added file/function/line fields to FileProviderLogMessage and encoded them only in #if DEBUG.
  • Appended source location to unified logging output (debug builds) and adjusted some path interpolations to use explicit .public privacy.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
.../Log/FileProviderLogging.swift Updates the logging protocol API to carry source location info.
.../Log/FileProviderLogger.swift Passes caller #filePath/#function/#line through the logger convenience methods.
.../Log/FileProviderLogMessage.swift Adds source fields to the JSON log model and conditionally encodes them in debug builds.
.../Log/FileProviderLog.swift Threads source location through log writing and appends it to unified logs (debug).
Comments suppressed due to low confidence (1)

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Log/FileProviderLog.swift:219

  • When details is empty you early-return after logging only the message, so the new file:function:line context is omitted for those log entries. To match the PR’s intent, include the source location even when there are no details (e.g., log message + "file:line function" in the empty-details branch too).
        if details.isEmpty {
            logger.log(level: level, "\(message, privacy: .public)")
            return
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@i2h3 i2h3 force-pushed the i2h3/feature/extended-debug-logging branch from d6072da to f5dd749 Compare February 10, 2026 13:30
@i2h3 i2h3 requested a review from Copilot February 10, 2026 13:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ging in debug builds.

Also fixed some unnecessary masking.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/feature/extended-debug-logging branch from f5dd749 to a31b12f Compare February 10, 2026 13:59
@i2h3 i2h3 requested a review from Copilot February 10, 2026 13:59
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9437.zip

Digest: sha256:c4f78d97554608e01f54d8a544303977a613137f846494e5e3903e989d146941

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@i2h3 i2h3 merged commit d88fe5a into master Feb 10, 2026
30 checks passed
@i2h3 i2h3 deleted the i2h3/feature/extended-debug-logging branch February 10, 2026 15:21
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system.

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

1 participant