Conversation
3b7dbf2 to
06e7924
Compare
mejo-
reviewed
Sep 10, 2024
Member
mejo-
left a comment
There was a problem hiding this comment.
I have no idea about owncloud and their custom groups functionality, but apart from one comment i didn't spot anything obvious
06e7924 to
cf26281
Compare
mejo-
approved these changes
Sep 10, 2024
Member
mejo-
left a comment
There was a problem hiding this comment.
Code changes look sensible now. Thanks for adding additional context to the PR description. I didn't test this, bug I guess you did 😉
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
3b755eb to
49e748d
Compare
Member
Author
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/1685/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1bbc440e ee7d2d67 49e748da
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1685/stable30Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate owncloud's Custom Groups to Teams
for each Custom Group (CG):
original data