Notification spammed for calendar event

[provokateurin]

Steps to reproduce

1. Run NC 24
2. Have a recurring calendar event like this:

BEGIN:VCALENDAR
CALSCALE:GREGORIAN
VERSION:2.0
PRODID:-//IDN nextcloud.com//Calendar app 3.5.0//EN
BEGIN:VEVENT
CREATED:20221010T152948Z
DTSTAMP:20221024T082910Z
LAST-MODIFIED:20221024T082910Z
SEQUENCE:3
UID:1a9d0c8a-f464-43f9-a907-912e8b2c0f7c
DTSTART;TZID=Europe/Berlin:20221011T190000
DTEND;TZID=Europe/Berlin:20221011T210000
STATUS:CONFIRMED
SUMMARY:pfadfinder
RRULE:FREQ=WEEKLY;BYDAY=TU
EXDATE;TZID=Europe/Berlin:20221025T190000
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER;RELATED=START:-PT1H
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
TZID:Europe/Berlin
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

4. Upgrade to NC 25
5. Get push notification spam for non-existent reminder

Expected behaviour

I should only get push notifications for the reminders i configured in the calendar event

Actual behaviour

I get a push notification every 10 minutes until the event. This starts one hour before the event starts, but that is also the only reminder I configured for the events.
This only happened with this one recurring event after the upgrade to NC 25, but I didn't update the event in any way.
I have another recurring calendar event that also existed before the upgrade, but I never got the push notification spam there until TODAY, so this is twice as annoying for me now. I did move it to a different day at some point, but I'm unsure if that was right before or after the upgrade.

Server configuration

Operating system: Docker alpine

Web server: nginx

Database: PostgreSQL

PHP version: 8.1

Nextcloud version: 25.0.1

Where did you install Nextcloud from: Docker/Helm Chart

Signing status:

No errors have been found.

List of activated apps:

Enabled:
  - activity: 2.17.0
  - calendar: 4.1.0
  - checksum: 1.2.0
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - collectives: 2.1.1
  - comments: 1.15.0
  - contacts: 5.0.1
  - contactsinteraction: 1.6.0
  - cookbook: 0.10.1
  - dashboard: 7.5.0
  - dav: 1.24.0
  - event_update_notification: 2.0.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - firstrunwizard: 2.14.0
  - holiday_calendars: 0.2.1
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - news: 19.0.0
  - nextcloud_announcements: 1.14.0
  - notes: 4.6.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - password_policy: 1.15.0
  - photos: 2.0.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recommendations: 1.4.0
  - related_resources: 1.0.3
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - tasks: 0.14.5
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 7.0.0
  - twofactor_webauthn: 1.0.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - admin_audit
  - bruteforcesettings: 2.3.0
  - encryption
  - extract: 1.3.5
  - files_external: 1.15.0
  - suspicious_login
  - user_ldap

Nextcloud configuration:

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": "6379",
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "cloud.provokateurin.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "25.0.1.1",
        "overwrite.cli.url": "https:\/\/cloud.provokateurin.de",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "overwriteprotocol": "https",
        "maintenance": false,
        "theme": "",
        "loglevel": 2
    }
}

Are you using an external user-backend, if yes which one: None

[provokateurin]

The other calendar event I'm getting spammed for now:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:DAVx5/4.2.4-ose ical4j/3.2.5
BEGIN:VEVENT
DTSTAMP:20221124T091151Z
UID:bbbc0d5d-335a-49e5-a9f3-79affe26577c
SEQUENCE:1
SUMMARY:[REDACTED]
DTSTART;TZID=Europe/Berlin:20221124T091500
DTEND;TZID=Europe/Berlin:20221124T101500
RRULE:FREQ=WEEKLY;WKST=MO;BYDAY=TH
EXDATE;TZID=Europe/Berlin:20221201T091500
CLASS:PUBLIC
STATUS:CONFIRMED
BEGIN:VALARM
TRIGGER:-PT1H
ACTION:DISPLAY
DESCRIPTION:höllermann
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
TZID:Europe/Berlin
LAST-MODIFIED:20220816T024022Z
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19810329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19961027T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

[nickvergessen]

Do you have a screenshot of the notification, so I can see which part to look into?
Because the notification app does not at all know anything about reminders etc.

[provokateurin]

I'd have to wait for that until next Tuesday, but it's just the normal reminder push notification. There is no new notification, only the new push notification.

[provokateurin]

I noticed it's not only push notifications, but it's real notifications every 5 minutes between the reminder and the event. I think something with the cronjob is going wrong there. I guess this should be moved to the calendar repo?

[provokateurin]

No wait, for the other event it's every 10 minutes?! Still has to be something with calendar.

[nickvergessen]

That part actually lives in server.
Is it our instance c.nc.c?
If it's another instance, do you know if there is something in the log file?

[provokateurin]

It's my personal instance and I checked the logs and there is nothing :/

[aledef]

Same issue here

[miaulalala]

Same issue here

please give a +1 to the original issue

[miaulalala]

Looks like the VALARM isn't parsed correctly any longer. cc @st3iny

[st3iny]

Looks like the VALARM isn't parsed correctly any longer. cc @st3iny

Related to nextcloud/server#34909? (I really hope it isn't 🤞)

[aledef]

+1

[miaulalala]

We have some logging. @provokateurin can you please enable debug logging for your instance and look for reminders to process? I would like to know if the number of reminders decreases or stays relatively the same.

\Sabre\VObject\Component\VAlarm::getEffectiveTriggerTime is where VALARMS are parsed.
\OCA\DAV\CalDAV\Reminder\ReminderService::getRemindersForVAlarm another one that could be the culprit. I don't have time to investigate yet but will put this on my to do.