Merged
Conversation
|
Test summaryRun details
Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||||||||||
skjnldsv
requested review from
artonge,
come-nc,
miaulalala,
sorbaugh and
yemkareems
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/activity-upload-public
branch
from
ce10ac4 to
7d045b8
Compare
yemkareems
approved these changes
Aug 7, 2024
sorbaugh
approved these changes
Aug 7, 2024
Altahrim
approved these changes
Aug 7, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with nextcloud/server#46945
I'm not so fond of the way it works, but the activity api handles things like this.
I would have liked notifications to be bound to the event category and not the event identifier, but that's not how it was designed 🤷