Skip to content

fix(dav): remove sharing attributes from default dav fetch and change duplicate registration from error to warn#902

Merged
Pytal merged 1 commit intomainfrom
fix/warning-files
Mar 5, 2024
Merged

fix(dav): remove sharing attributes from default dav fetch and change duplicate registration from error to warn#902
Pytal merged 1 commit intomainfrom
fix/warning-files

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 4, 2024

image

We moved those attributes to the files_sharing app, since we can disable the app.

Fix nextcloud/server#43953

@skjnldsv skjnldsv added the 3. to review 3️⃣ Waiting for reviews label Mar 4, 2024
@skjnldsv skjnldsv requested a review from susnux March 4, 2024 15:21
@skjnldsv skjnldsv self-assigned this Mar 4, 2024
@skjnldsv skjnldsv marked this pull request as ready for review March 4, 2024 15:22
… duplicate registration from `error` to `warn`

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/warning-files branch from a74361d to af001fc Compare March 4, 2024 15:25
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (e428bb6) to head (af001fc).
Report is 244 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
+ Coverage   77.17%   77.50%   +0.32%     
==========================================
  Files          17       17              
  Lines         403      440      +37     
  Branches      108      118      +10     
==========================================
+ Hits          311      341      +30     
- Misses         91       98       +7     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv requested review from Pytal, artonge and emoral435 March 5, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review 3️⃣ Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error files: nc:share-attributes already registered, files: oc:share-types already registered, files: ocs:share-permissions already registered

3 participants