feat(sidebar): provide a proxy for the files sidebar#1306
Merged
Conversation
susnux
force-pushed
the
feat/sidebar-api
branch
from
ccf8eb7 to
3124c4e
Compare
susnux
force-pushed
the
feat/sidebar-api-v2
branch
from
2884d99 to
c10176b
Compare
susnux
added
type: enhancement
artonge
approved these changes
Dec 16, 2025
susnux
force-pushed
the
feat/sidebar-api-v2
branch
from
c10176b to
0602156
Compare
Additionally to registering sidebar tabs this also provides a public interface to access the sidebar itself. Which can be used to retrieve or set the currently active tab, allows to open or close it and getting the open state. We can then use this proxy to later add fallbacks for different Nextcloud versions once we modernized the files sidebar, so apps can stick with this interface regardless of the Nextcloud version and implementation used underneath. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/sidebar-api-v2
branch
from
0602156 to
570a190
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 91.21% 89.66% -1.56%
==========================================
Files 24 25 +1
Lines 694 706 +12
Branches 189 191 +2
==========================================
Hits 633 633
- Misses 50 62 +12
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- based upon #1305Additionally to registering sidebar tabs this also provides a public interface to access the sidebar itself.
Which can be used to retrieve or set the currently active tab, allows to open or close it and getting the open state.
We can then use this proxy to later add fallbacks for different Nextcloud versions once we modernized the files sidebar, so apps can stick with this interface regardless of the Nextcloud version and implementation used underneath.