NVSHAS-9912 - Adding role and rolebinding for neuvector-store-secret#489
Merged
venkateshjayagopal merged 1 commit intoneuvector:masterfrom Apr 30, 2025
venkateshjayagopal:master
Merged
NVSHAS-9912 - Adding role and rolebinding for neuvector-store-secret#489venkateshjayagopal merged 1 commit intoneuvector:masterfrom venkateshjayagopal:master
venkateshjayagopal merged 1 commit intoneuvector:masterfrom
venkateshjayagopal:master
Conversation
Contributor
holyspectral
left a comment
holyspectral
left a comment
There was a problem hiding this comment.
Generally looks good to me. Maybe we don't need accesses to all secrets?
Contributor
|
Please make sure that you squash commits before you merge. |
williamlin-suse
requested changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to handle role and rolebinding addition for neuvector-store-secret. Tested with default and leastPrivilege deployment on both Native K8s and Openshift cluster.