Replace httpx with requestx HTTP client library #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the OpenAI Python SDK from httpx to requestx, a Rust-based HTTP client that is API-compatible with httpx. Key changes: - Replace httpx dependency with requestx from GitHub (neuesql/requestx) - Replace respx mock library with neuesql/respx fork (for tests) - Update all imports: `import httpx` -> `import requestx as httpx` - Add compatibility layer for missing requestx features: - QueryParams class in _compat.py (requestx lacks this) - url_copy_with_raw_path() helper (requestx's copy_with lacks raw_path param) - Refactor DefaultHttpxClient/DefaultAsyncHttpxClient to use factory functions instead of subclassing (requestx classes don't support super().__init__(**kwargs)) - Disable httpx_aiohttp integration (incompatible with requestx) - Update CLI proxy configuration to use requestx's Proxy API Incompatibilities and limitations: - Python 3.12+ required (requestx requirement) - httpx_aiohttp is not supported - Custom HTTPTransport not supported (use Proxy objects instead) - respx mocking has issues (Response class not subclassable) - Some httpx internal APIs not available (_config module) https://claude.ai/code/session_01LNGCMPexQ9NESHdPMdSCXj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
This PR replaces the
httpxHTTP client library withrequestx, a Rust-based implementation that provides a simplified API compatible with httpx.Key Changes:
Dependency Update: Changed from
httpx>=0.23.0, <1torequestx @ git+https://github.com/neuesql/requestx.git@v1.0.5inpyproject.tomlImport Changes: Updated all imports throughout the codebase from
import httpxtoimport requestx as httpxfor compatibilityAPI Compatibility Layer: Created
src/openai/_compat.pywith compatibility shims:QueryParamsclass to replace httpx's QueryParams (requestx doesn't have this)url_copy_with_raw_path()function to handle URL manipulation differencesClient Wrapper Changes:
_DefaultHttpxClientand_DefaultAsyncHttpxClientfrom subclasses to factory functions since requestx clients (implemented in Rust) don't support subclassingSyncHttpxClientWrapperandAsyncHttpxClientWrapperto use composition instead of inheritanceURL/Query Parameter Handling:
url.copy_with(params=...)tourl.copy_with(query=...)where neededraw_pathoperationsProxy Configuration:
httpx.Proxy(http=..., https=...)instead ofHTTPTransportRemoved Dependencies:
httpx_aiohttpfrom optional dependencies as it's not compatible with requestxrespxto use a custom fork for requestx compatibilityDocumentation Updates: Updated README examples to show requestx usage and added notes about API differences
Compatibility Notes:
HTTPTransportare not supportedaiohttpclient option is no longer availableAdditional context & links
This change enables the use of requestx, a high-performance Rust-based HTTP client that maintains API compatibility with httpx while providing better performance characteristics.
https://claude.ai/code/session_01LNGCMPexQ9NESHdPMdSCXj