Bump to core-3.0.0, move to vitest, support ESM modules#587
Merged
Conversation
3b68110 to
3d2921a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const commit = "commit" | ||
| const discussionCategory = "discussionCategory" | ||
| const generateReleaseNotes = true | ||
| const _generateReleaseNotes = true |
There was a problem hiding this comment.
Unused constant _generateReleaseNotes is dead code
Low Severity
The constant _generateReleaseNotes is declared but never used anywhere in the file. The createAction function uses a literal default value generateReleaseNotes = true directly in its parameter list, making this constant unnecessary dead code.
| const mockGetInput = vi.mocked(core.getInput) | ||
| const mockGetBooleanInput = vi.mocked(core.getBooleanInput) | ||
| const mockReadFileSync = vi.mocked(fs.readFileSync) | ||
| const _mockStatSync = vi.mocked(fs.statSync) |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Moderate risk because it changes the module system to ESM and updates GitHub Actions dependencies/test tooling, which can affect runtime imports and CI behavior despite minimal functional logic changes.
Overview
Moves the project to ESM and Vitest-based testing. Tests are migrated from Jest to
vitest, including new__mocks__for@actions/coreandfs, updated mocking patterns, and updated imports to use explicit.jsextensions.Updates tooling/config. Enables Biome v2 linting/organize-imports configuration, adds a
vitest.config.tswith coverage thresholds, bumps@actions/coreto^3.0.0, and expands.gitignorefor Copilot/Claude local settings.Written by Cursor Bugbot for commit c4c6215. This will update automatically on new commits. Configure here.