IC - 20200226 #361
Merged
IC - 20200226 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling memset too late after assigning the `sem` variable in the code of `OS_BinSemCreate_Impl` caused the data pointed to by `sem` to get corrupted. The issue was not caught by the existing test suite for POSIX OSAL when running on Linux. However running the test suite on macOS revealed the anomalies in the behavior of `pthread_cond_destroy()` which was working on the corrupted memory as was demonstrated in: Calling pthread_cond_destroy results in “Function not implemented” ENOSYS on macOS, https://stackoverflow.com/questions/59560940/calling-pthread-cond-destroy-results-in-function-not-implemented-enosys-on-mac?noredirect=1#comment105301077_59560940 The original commit that introduced the issue is: bfa7a33
Fix #337, fix memory corruption produced by misplaced memset()
Merged
Contributor
Author
|
@acudmore does this need to be tested on other platforms? |
Contributor
Author
|
CCB 20200226 - Check if tests needed on other platforms. If CI tests are enough then approve. |
ghost
approved these changes
Feb 27, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good to me. If it passes the CI build, it should not need to be tested on any other platform.
astrogeco
added
the
CCB:Approved
astrogeco
force-pushed
the
ic-20200226
branch
from
0bec7ab to
7d1f33d
Compare
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #338
Testing performed
Steps taken to test the contribution:
Expected behavior changes
#338 - Fixes memset bug in
src/os/posix/osapi.cSystem(s) tested on
CI: Ubuntu 18.04
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz - NASA/GSFC