Correct error checking for taskSpawn #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for failure of taskSpawn should be for the value of ERROR, not 0, per the VxWorks API documentation. Found when implementing the unit test improvements in nasa#230. This issue is generally only reproducible in UT where taskSpawn can be made to fail.
skliper
approved these changes
Oct 21, 2019
Contributor
|
CCB - 20191023: reviewed and approved |
skliper
added
the
CCB:Approved
skliper
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #269, Corrects the error check after taskSpawn in the vxworks implementation.
The test for failure of taskSpawn should be for the value of
ERROR, not 0, per the VxWorks API documentation.
Found when implementing the unit test improvements in #230.
This issue is generally only reproducible in UT where taskSpawn
can be made to fail. In normal FSW/runtime use, the taskSpawn
call is not likely to fail, and this issue cannot be seen.
Testing performed
Build OSAL coverage tests (see #268) and confirm passage of all tests.
Expected behavior changes
All unit tests pass, fixes a failure in one test due to this incorrect error test.
System(s) tested on:
Ubuntu 18.04.2 LTS 64-bit
Contributor Info
Joseph Hickey, Vantage Systems, Inc.