Skip to content

Conversation

@myc-yang
Copy link

@myc-yang myc-yang commented Jun 2, 2025

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Steps taken to test the contribution:

  1. Unit tests passed with address sanitizer enabled

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • Unit tests will now pass when address-sanitizer is enabled

System(s) tested on

  • OS: Ubuntu 20.04.6

@myc-yang myc-yang force-pushed the fix-sc-unit-test-for-address-sanitizer branch from 19c7118 to 72410bd Compare June 2, 2025 16:13
@myc-yang myc-yang changed the base branch from main to draco-rc5-eval June 2, 2025 16:15
SC_AtsEntryHeader_t *Entry;
SC_AtsInfoTable_t AtsInfoTbl;
uint32 AtsTable[SC_ATS_BUFF_SIZE32];
uint32 Big_AtsTable[SC_ATS_BUFF_SIZE32 * 2];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale for doubling the table size?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was a specific rationale for doubling it. I just wanted to make sure it was big enough to prevent an overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants