Fix and improvements in String class#248
Conversation
- Add empty TrimLeft() and TrimRight() methods. - Add nullable notation to all relevant methods. - Add compiler defs to those. - Fix order of methods to make them adjancent. - General improvements in IntelliSense comments. - Code clean-up. - Fix using declaration.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Unit tests failing because of change in mscorlib signature. Merging anyway. |
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: