[menu] Add pressMode option to the MenuTrigger
#3634
+106
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuganzy
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
PR: out-of-date
chuganzy
force-pushed
the
menu-press-mode
branch
from
a3d0917 to
096107d
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
added
the
component: menu
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # packages/react/src/menu/trigger/MenuTrigger.tsx
chuganzy
force-pushed
the
menu-press-mode
branch
from
096107d to
81ab430
Compare
github-actions
bot
removed
the
PR: out-of-date
Member
|
Can we for starter create a demo for this? To see how it looks in user-land and then decide if we want to have it as a feature directly in the component. |
Contributor
Author
|
@mnajdova Thanks for taking a look! Sure, I can add a demo later. In the meantime, the CodeSandbox I shared already includes this. Although it is very rough, please refer to the "AFTER" section to see how it looks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pressModeoption toMenuTrigger.Currently,
Menuopens onmousedown, which allows users to drag directly to select a menu item. This is a nice and intentional interaction design, however, there are cases where this behavior is not suitable.https://codesandbox.io/p/sandbox/z2jwsl
For example, when the element wrapping the trigger is draggable, it can be necessary to distinguish between a drag gesture and a menu interaction. In such cases, opening the menu on
clickrather thanmousedownprovides more appropriate behavior.There is a related discussion in Radix:
radix-ui/primitives#2867
At the moment, this behavior can be implemented using
onOpenChange/preventBaseUIHandler, but I thought it would be beneficial to support this use case directly in Base UI via an explicit option.Please note that this PR will conflict with #3631. I will address it as needed.