This repository was archived by the owner on Sep 2, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Support rtable on OpenBSD #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 86.76% 86.80% +0.04%
==========================================
Files 5 5
Lines 559 561 +2
Branches 559 561 +2
==========================================
+ Hits 485 487 +2
Misses 48 48
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
larseggert
approved these changes
Mar 10, 2025
Collaborator
larseggert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a merge would need to wait until the OpenBSD rust package is at 1.82, so we can run CI.
Contributor
Author
|
That won't happen until 7.7, which is usually around April. On -current, |
Collaborator
|
I also started #103 but no dice. |
Collaborator
|
Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD supports multiple routing tables. The current code doesn't account for that and instead always request the route for routing table 0. If the process is run in another rtable, then this operation will get stuck.
getrtableisn't part oflibccrate, but part of OpenBSD's libc. The cast is safe: the syscall never fails, and the actual values are between 0 and 255.Additional details can be found in: