added logger to debug the sendotp response

[nandhu-kumar]

Summary by CodeRabbit

• Chores
  • Enhanced logging for OTP response handling to improve system observability and debugging capabilities during authentication operations.

[coderabbitai]

Walkthrough

The sendOTP() method in HelperService now includes two additional logging statements to output the inner OTP response—once in JSON format and once as a raw object. These logs are placed before the return statement without affecting control flow or returned values.

Changes

Cohort / File(s)	Summary
Logging Enhancement mosip-identity-plugin/src/main/java/io/mosip/esignet/plugin/mosipid/service/HelperService.java	Added two logging statements in sendOTP() to output the inner OTP response in both JSON-serialized and raw object formats for improved observability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops 'round the logs with delight,
Two new lines bringing visibility to night,
JSON and raw, both shine so bright,
Debugging made easier—what a sight!
Hop, hop, hop—the code's just right! 🌙

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'added logger to debug the sendotp response' accurately describes the main change: adding logging statements to debug the sendOTP response in HelperService.sendOTP().

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@mosip-identity-plugin/src/main/java/io/mosip/esignet/plugin/mosipid/service/HelperService.java`:
- Around line 159-160: The current info-level logs in HelperService (the
log.info lines referencing
objectMapper.writeValueAsString(idaSendOtpResponse.getResponse()) and
idaSendOtpResponse.getResponse()) expose masked contact metadata and call
objectMapper.writeValueAsString which can throw after the OTP side-effect;
change these to a guarded debug-only log (wrap with log.isDebugEnabled()) that
logs only non-sensitive derived fields (e.g., boolean flags like hasMaskedEmail,
hasMaskedMobile or String masks returned by getMaskedEmail/getMaskedMobile) and
remove the direct objectMapper.writeValueAsString call (or wrap it in try/catch
and swallow exceptions) so JSON processing errors cannot alter the method
outcome after the OTP was sent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0c190fc4-3992-404b-8e05-db13b737fae5

📥 Commits

Reviewing files that changed from the base of the PR and between d0246c0 and a155125.

📒 Files selected for processing (1)

• mosip-identity-plugin/src/main/java/io/mosip/esignet/plugin/mosipid/service/HelperService.java