This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Correct testing behavior for safe cast#91
Merged
MerlinEgalite merged 2 commits intomainfrom Dec 19, 2022
Merged
Conversation
MathisGD
approved these changes
Dec 10, 2022
Rubilmax
approved these changes
Dec 14, 2022
Collaborator
Rubilmax
left a comment
Rubilmax
left a comment
There was a problem hiding this comment.
This seems like a great test case for fuzzing
Contributor
Author
yep! will push that |
Collaborator
|
You didn't push right ? |
Contributor
Author
Yes forgot it lol 😅 |
MathisGD
approved these changes
Dec 16, 2022
Collaborator
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
Note that you could also have fuzzed the address
Rubilmax
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forme tests where testing for the wrong value (
uint128instead ofuint96)