This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Memoization of size in the 3-heap#84
Merged
QGarchery merged 3 commits intofeat/three-heapfrom Nov 11, 2022
Merged
Conversation
QGarchery
requested review from
MathisGD,
MerlinEgalite,
Rubilmax and
pakim249CAL
MerlinEgalite
approved these changes
Nov 11, 2022
Contributor
MerlinEgalite
left a comment
MerlinEgalite
left a comment
There was a problem hiding this comment.
It would be nice to have a gas comparison since it's difficult to know if it saves gas or not. (I think so but not sure)
MathisGD
approved these changes
Nov 11, 2022
Collaborator
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
LGTM. This would be a great use of Transient storage, in the future.
Merged
Collaborator
|
|
Contributor
Yep, however, I'm not sure you can do it with a struct and a lib... |
pakim249CAL
approved these changes
Nov 11, 2022
MathisGD
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reorders arguments to have heap then size (the initial state), and the the specific arguments of the functions like
_idor_value.