This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Conversation
MathisGD
requested review from
MerlinEgalite,
QGarchery,
Rubilmax and
pakim249CAL
pakim249CAL
approved these changes
Oct 12, 2022
MerlinEgalite
suggested changes
Oct 14, 2022
Contributor
MerlinEgalite
left a comment
MerlinEgalite
left a comment
There was a problem hiding this comment.
Can you try it please? Else LGTM!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization of
HeapOrdering. See each commit as a separated optimization, we can keep each of them separately. My preferred one is the first one, the second and the first one adding a little bit of code.See the results for
updateHeapinTestRandomHeapOrdering:Gas before: 21922
Gas after: 21811