invert if statements that could cause a unexpected short circuits #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en e is set in shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the code is running in a shell or non interactive environment with
set -eo pipefailcalled previously then one-line shorthand-form if statements that have no false path handle will bubble an error up immediately. Much of the code does not expect for this flag to be set.I scrubbed through the scripts pretty quick and used De Morgans' law to adjust them.
I'm pretty sure the main issue my installer is having is around "./scripts/gvm-default" specifically when running
source "$HOME/.gvm/scripts/gvm"if this looks too dense.I also left lines like
[[ -s "$HOME/.gvm/scripts/gvm" ]] && source "$HOME/.gvm/scripts/gvm"alone because it's technically a line present on people's rc files and pattern matching that is performed would need to be adjusted.Thanks for your consideration.