Merged
Conversation
Member
|
Found one reference in |
Remove unused package from client which brings in buildkit dep Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
client-remove-buildkit-dep
branch
from
843bb97 to
aae26b8
Compare
Member
Author
|
Updated that use. If we want in the future, we could expose the dialer functions, but we should not be exposing interface to craft buildkit options in the client module. |
AkihiroSuda
approved these changes
Jul 3, 2025
crazy-max
approved these changes
Jul 9, 2025
vvoland
approved these changes
Jul 9, 2025
vvoland
added
impact/changelog
impact/deprecation
kind/refactor
github-project-automation
bot
moved this from In Progress
to Done
in go modules transition
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package does not need to be in the client package. It is not used anywhere and no one imports it (https://pkg.go.dev/github.com/docker/docker@v28.3.0+incompatible/client/buildkit) and it creates a buildkit dependency from the future client module.