Fixes for some issues

[mb706]

Fixes for: #180 #181 #182

[coveralls]

Coverage decreased (-0.03%) to 96.03% when pulling 8096d71 on mb706:mb706_fixes into e233aa7 on berndbischl:master.

[coveralls]

Coverage decreased (-0.03%) to 96.03% when pulling b98b927 on mb706:mb706_fixes into e233aa7 on berndbischl:master.

[mb706]

The nice thing about sapply is that it gives list() in case of length(x) == 0, which would match quite nicely with the actual default being list(). When the related BBmisc issue gets fixed, this will result in the most natural printout. vcapply will give character(0) when x is list(), which is a deviation from the behaviour of the other "vector" types (which always show logical(0), numeric(0) etc. depending on their type).

Not going to say much about the syntax error here.

[jakob-r]

Sorry about the typo. But in the documentation we say that the output is a character vector.

[mb706]

You're right, I didn't consider the other points from which discreteValueToName gets called. I'd still say the printout of a discreteVectorLearnerParam with default list() shouldn't have character(0) in it.

[mb706]

My comment still stands

[coveralls]

Coverage decreased (-0.03%) to 96.03% when pulling c19ca1f on mb706:mb706_fixes into e233aa7 on berndbischl:master.

[coveralls]

Coverage increased (+0.2%) to 96.268% when pulling a3d2c6a on mb706:mb706_fixes into e233aa7 on berndbischl:master.

[jakob-r]

Because this thread is invisible let's continue it here:

@mb706 wrote: You're right, I didn't consider the other points from which discreteValueToName gets called. I'd still say the printout of a discreteVectorLearnerParam with default list() shouldn't have character(0) in it.

I agree in this point. You mentioned it here but the conversion to character(0) is already here (discreteValueToName). But it could also be fixed in paramValueToString.Param.

[mb706]

> makeDiscreteVectorLearnerParam("x", NA, values=c("a", "b", "c"), default = list())
            Type len    Def Constr Req Tunable Trafo
1 discretevector  NA list()  a,b,c   -    TRUE     -
Used: train.

looks nice.