Skip to content

Local dev improvements#53

Merged
jschr merged 4 commits intomasterfrom
local-dev-improvements
Nov 19, 2025
Merged

Local dev improvements#53
jschr merged 4 commits intomasterfrom
local-dev-improvements

Conversation

@jschr
Copy link
Member

@jschr jschr commented Nov 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 17, 2025 15:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances local development capabilities by making the nginx proxy server configurable to listen on different network interfaces (not just localhost) and adds Mac-specific development tooling.

  • Introduces a configurable HOST environment variable (defaulting to 127.0.0.1) that allows the proxy to bind to different interfaces like 0.0.0.0 for container accessibility
  • Creates a new docker-compose.dev-mac.yml specifically for Mac development with volume mounts for logs and cache data
  • Updates documentation to include certificate error handling flags for Chrome

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/generate_conf_files.sh Adds HOST variable configuration with default value and includes it in nginx template substitution
docker-compose.yml Formatting improvements for consistency (indentation and quote style)
docker-compose.dev-mac.yml New Mac-specific development compose file with HOST=0.0.0.0, logging enabled, and local volume mounts
conf/nginx.conf.server.template Updates all listen directives to use the configurable HOST variable instead of hardcoded 127.0.0.1
README.md Adds --ignore-certificate-errors flag to Chrome proxy configuration example
.gitignore Excludes /data directory used for local development volumes
Comments suppressed due to low confidence (1)

scripts/generate_conf_files.sh:163

  • The variable name ENABLE_LOGGING appears to be incorrect. Based on the codebase, the actual variable used for controlling access logs is ENABLE_ACCESS_LOGS (see line 58). This line should likely be:
printf 'ENABLE_ACCESS_LOGS=%s\n' "$ENABLE_ACCESS_LOGS"
printf 'CONTENT_CACHE_DIR=%s\n' "$CONTENT_CACHE_DIR"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 17, 2025 15:34

This comment was marked as resolved.

@jschr jschr merged commit 21a6c47 into master Nov 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants