Skip to content

Custom field reordering #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
navjottomer merged 2 commits into from
Dec 27, 2021
Merged

Custom field reordering #464

navjottomer merged 2 commits into from
Dec 27, 2021

Conversation

@patriksh
Copy link
Contributor

@patriksh patriksh commented Dec 26, 2021

@patriksh
Custom field reordering
54147a4
@patriksh
Fix number field error
0272427 
Cannot access offset of type string on string
@navjottomer navjottomer merged commit 37671e5 into mindstellar:develop Dec 27, 2021
@patriksh
Copy link
Contributor Author

patriksh commented Dec 27, 2021

Made an oopsie with the number field fix...

Should be if ($field['e_type'] === 'DATEINTERVAL' || ($field['e_type'] === 'NUMBER' && $search)) { so from and to is used only on search. Can you just fix it so I don't make a new PR?

navjottomer added a commit that referenced this pull request Dec 27, 2021
@navjottomer
Fix #464 some mistakes
b9e6141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patriksh @navjottomer