Skip to content

Modularize minor fixes#1238

Merged
KenitoInc merged 10 commits intomicrosoftgraph:modularizefrom
SamErde:se-modularize-review
Dec 19, 2024
Merged

Modularize minor fixes#1238
KenitoInc merged 10 commits intomicrosoftgraph:modularizefrom
SamErde:se-modularize-review

Conversation

@SamErde
Copy link
Contributor

@SamErde SamErde commented Nov 28, 2024

A few code quality updates:

  • Fix spelling and typos
  • Add missing catch blocks
  • Add missing begin/end blocks
  • Add missing OutputType
  • Remove extra whitespace
  • Remove improper trailing commas in JSON

@SamErde SamErde requested a review from a team as a code owner November 28, 2024 16:06
@learn-build-service-prod
Copy link

Learn Build status updates of commit f5877f3:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.build.ps1 ✅Succeeded
module_legacy/docfx.json ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnit.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnitMember.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAttributeSet.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditDirectoryLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditSignInLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinition.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinitionAllowedValue.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraFeatureRolloutPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraObjectSetting.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Remove-EntraPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Set-EntraPolicy.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaApplicationPasswordCredential.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Set-EntraBetaDirSyncFeature.ps1 ✅Succeeded
src/CompatibilityAdapterBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteveMutungi254 SteveMutungi254 added Ready For Review The PR Ready for Review P0 Highest priority labels Dec 5, 2024
@learn-build-service-prod
Copy link

Learn Build status updates of commit be43b5d:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.build.ps1 ✅Succeeded
module_legacy/docfx.json ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnit.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAdministrativeUnitMember.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAttributeSet.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditDirectoryLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraAuditSignInLog.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinition.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraCustomSecurityAttributeDefinitionAllowedValue.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraFeatureRolloutPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Get-EntraObjectSetting.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Remove-EntraPolicy.ps1 ✅Succeeded
module_legacy/Entra/AdditionalFunctions/Set-EntraPolicy.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaApplicationPasswordCredential.ps1 ✅Succeeded
module_legacy/EntraBeta/AdditionalFunctions/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/Entra/Microsoft.Entra/DirectoryManagement/Get-EntraDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Get-EntraBetaDirectoryObjectOnPremisesProvisioningError.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/DirectoryManagement/Set-EntraBetaDirSyncFeature.ps1 ✅Succeeded
src/CompatibilityAdapterBuilder.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@SamErde
Copy link
Contributor Author

SamErde commented Dec 19, 2024

Resolved two new conflicts.

@KenitoInc KenitoInc merged commit 5cce428 into microsoftgraph:modularize Dec 19, 2024
2 checks passed
@SamErde SamErde deleted the se-modularize-review branch December 19, 2024 14:15
KenitoInc pushed a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Highest priority Ready For Review The PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants