Further cleanup on layout.ts #281901
Merged
Further cleanup on layout.ts #281901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
benibenj
previously approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR complements #281773 by refactoring the panel hiding logic in setPanelHidden() to fix a timing issue (#281772) when hiding a maximized panel. The changes reorder when the panel unmaximize operation occurs relative to other state updates.
- Moves the
isPanelMaximized()call earlier (before runtime state changes) to capture the initial maximized state - Repositions the unmaximize operation to occur before the grid visibility change rather than after all panel visibility logic
- Updates the comment to reflect the reason for the fix (preventing conflicts) rather than the previous caching-related explanation
joaomoreno
force-pushed
the
joao/indigo-constrictor
branch
from
0063c2b to
1ad4793
Compare
benibenj
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to #281773