fix: ensure finishedEditing is called in ChatWidget #281763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the finishedEditing() method was not being called when the ChatWidget's model is cleared or switched to a different session. This ensures proper cleanup of editing state, preventing state leaks in the chat editing UI.
Key Changes
- Added
finishedEditing()call whensetModelis called withundefined(clearing the model) - Added
finishedEditing()call whensetModelis called with a different model (switching sessions)
justschen
approved these changes
Dec 12, 2025
Collaborator
justschen
left a comment
justschen
left a comment
There was a problem hiding this comment.
good catch, thank you!
dmitrivMS
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ensure finishedEditing is called in ChatWidget. Fix #281734