Fix backward selection when EditContext is off #273150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes backward selection handling in the TextArea edit context when EditContext is off. The issue was that the selection direction wasn't being properly accounted for when converting from editor selection state to textarea state.
Key Changes:
- Added
SelectionDirectionparameter tofromScreenReaderContentStatemethod - Swapped
selectionStartandselectionEndfor RTL (right-to-left) selections
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| textAreaEditContextState.ts | Modified fromScreenReaderContentState to accept and handle selection direction, swapping start/end for RTL selections |
| textAreaEditContext.ts | Updated call site to pass selection direction to fromScreenReaderContentState |
…State to TextAreaState (microsoft#273146)
yavanosta
force-pushed
the
TextAreaState-backward-selection
branch
from
7e4c68c to
6e58b1f
Compare
Contributor
Author
|
Hi @aiday-mar is there anything I can do in this PR? |
Contributor
|
Hi thanks for the PR. It's good, we will get it merged. |
aiday-mar
approved these changes
Dec 16, 2025
bpasero
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #259042 fixing selectionDirection for
TextAreaEditContext.Fixes #273146