Fix editor edge clicking #262964
Merged
Fix editor edge clicking #262964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking the 10 left-most pixels of the editor, the cursor was moved to the beginning of the line. When clicking the 10 right-most characters of the editor, the cursor was moved to the end of the line. This is not correct in RTL. Clicking the left pixels should move the cursor to the left. Clicking the right pixels should move the cursor to the right.
Contributor
Author
|
Friendly ping @aiday-mar :) This is a bug in a feature that I myself introduced. I would love to see this fix land. |
aiday-mar
approved these changes
Dec 2, 2025
connor4312
approved these changes
Dec 2, 2025
Contributor
Author
|
This was approved 2 weeks and marked to auto-merge, but it’s still not merged. Looks like a prerequisite is missing. I think CI needs to run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the 10 left-most pixels of the editor, the cursor was moved to the beginning of the line. When clicking the 10 right-most characters of the editor, the cursor was moved to the end of the line. This is not correct in RTL. Clicking the left pixels should move the cursor to the left. Clicking the right pixels should move the cursor to the right.
This was an oversight in #255455.
Also the
horizontalScrollPaddingis hardcoded to 10. I noticed in my own editor this means I can’t put the cursor between the first two characters in VSCode. It will always snap to the beginning of the line. Should this be made configurable (in a separate PR)?