build: switch build/tsconfig.json to module: nodenext
#238426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm1
changed the title
build/tsconfig.json to module: nodenext
Member
|
This is great, thanks @tmm1! |
joaomoreno
approved these changes
Jan 22, 2025
Member
|
Looking forward to the leak fix in a future TypeScript version: microsoft/TypeScript#58137 We'll also reach out to the TypeScript team and nudge them. |
mjbvz
approved these changes
Jan 22, 2025
legomushroom
pushed a commit
that referenced
this pull request
Jan 22, 2025
* build/tsconfig: switch to module: nodenext for bun compat * build: rewrite imports for nodenext compat * build: re-generate
|
amazing |
Member
Are you specifically talking about a bun-related leak fix? I'm not sure that's specifically a bug in TS, given it does not affect other runtimes, and the proposed fix on that issue is not one that I personally think is one we should accept. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the ./build generated js code compatible with
bunUsing
buninstead ofnoderesults in faster compiles:cc @jrieken @deepak1556