Skip to content

Reland fix custom task shell doesn't work without manually passing in "run command" arg/flag #236058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 3 commits into from
Dec 17, 2024
Merged

Reland fix custom task shell doesn't work without manually passing in "run command" arg/flag #236058

meganrogge merged 3 commits into from
Dec 17, 2024

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Dec 13, 2024 •
edited by meganrogge
Loading

This PR relands #181760

Fix #181302
Fix #169821

Legend-Master
Legend-Master commented Dec 13, 2024
View reviewed changes
@meganrogge meganrogge enabled auto-merge (squash) December 13, 2024 16:44
meganrogge
meganrogge requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested various repos - this causes the default build task to fail in xterm.js for example

auto-merge was automatically disabled December 14, 2024 01:43

Head branch was pushed to by a user without write access

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Dec 14, 2024

Tested various repos - this causes the default build task to fail in xterm.js for example

I just tested the change in the https://github.com/xtermjs/xterm.js repo but I don't see any differences between with this change and without, do you mind adding some more details about how it failed?

@meganrogge
Copy link
Contributor

meganrogge commented Dec 16, 2024

Tested various repos - this causes the default build task to fail in xterm.js for example

I just tested the change in the https://github.com/xtermjs/xterm.js repo but I don't see any differences between with this change and without, do you mi

Screenshot 2024-12-16 at 10 33 40 AM nd adding some more details about how it failed?

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Dec 17, 2024

Sorry but it seems to be missing yarn to me, the command line args passed in by us seems to be right, do you mind sharing what the command line used without this change? I don't think it actually changed

@meganrogge
Copy link
Contributor

meganrogge commented Dec 17, 2024

Yep, my bad 🤦🏼‍♀️ 😄

@meganrogge meganrogge enabled auto-merge (squash) December 17, 2024 16:54
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 17, 2024
@meganrogge meganrogge merged commit 330ab6c into microsoft:main Dec 17, 2024
7 checks passed
@catskul catskul mentioned this pull request Dec 20, 2024
Open
@meganrogge meganrogge mentioned this pull request Dec 20, 2024
Merged
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

January 2025

Development

Successfully merging this pull request may close these issues.

Custom task shell executable doesn't work VS Code is still adding /d /c to task commands

3 participants

@Legend-Master @meganrogge @roblourens