Allow the .ndjson extension for the jsonl language #235921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDJSON is a specification that is essentially the same thing as JSON lines. The spec can be found on https://github.com/ndjson/ndjson-spec. The NDJSON website is down. The project seems pretty much dead. The status is best described by this comment: ndjson/ndjson-spec#35 (comment) However, this doesn’t mean there aren’t any `.ndjson` files out there. This changes adds `.ndjson` to the list of `jsonl` file extensions.
remcohaszing
commented
Dec 12, 2024
| "id": "jsonl", | ||
| "aliases": [ | ||
| "JSON Lines" | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
Maybe I should also add ndjson to aliases? I’m not really sure if that even does anything. There are some extensions that define the ndjson language ID.
Contributor
There was a problem hiding this comment.
aliases are only used for rendering labels (e..g in some native Save As dialogs)
aeschli
approved these changes
Dec 12, 2024
aeschli
approved these changes
Dec 12, 2024
| "id": "jsonl", | ||
| "aliases": [ | ||
| "JSON Lines" | ||
| ], |
Contributor
There was a problem hiding this comment.
aliases are only used for rendering labels (e..g in some native Save As dialogs)
Tyriar
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDJSON is a specification that is essentially the same thing as JSON lines. The spec can be found on https://github.com/ndjson/ndjson-spec.
The NDJSON website is down. The project seems pretty much dead. The status is best described by this comment:
ndjson/ndjson-spec#35 (comment)
However, this doesn’t mean there aren’t any
.ndjsonfiles out there. This changes adds.ndjsonto the list ofjsonlfile extensions.