Skip to content

Cli serve_web sets the path prefix to /<quality>-<commit>/, commit value parsing error #233986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connor4312 merged 1 commit into from
Nov 17, 2024
Merged

Cli serve_web sets the path prefix to /<quality>-<commit>/, commit value parsing error #233986

connor4312 merged 1 commit into from
Nov 17, 2024

Conversation

@BenLocal
Copy link
Contributor

@BenLocal BenLocal commented Nov 16, 2024

fix #233984

connor4312
connor4312 approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@connor4312 connor4312 enabled auto-merge (squash) November 16, 2024 18:00
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 16, 2024
@connor4312 connor4312 merged commit 4e2855f into microsoft:main Nov 17, 2024
6 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@connor4312 connor4312 connor4312 approved these changes

Assignees

@lramos15 lramos15

Labels

triage-needed

Projects

None yet

Milestone

November 2024

Development

Successfully merging this pull request may close these issues.

Cli serve_web sets the path prefix to /<quality>-<commit>/, commit value parsing error

4 participants

@BenLocal @deepak1556 @connor4312 @lramos15