Make sure link fragment is preserved #193743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree [company="Google"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="Google" |
rebornix
approved these changes
Oct 5, 2023
connor4312
approved these changes
Oct 5, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that the fragment part of a link is preserved when in a notebooks. There is existing special handing for links starting with
#, but not with both a path and a fragment part.Fixes #193742
To test this, create a link in a notebook markdown cell in the form of
When clicking on this link currently, you'll get a dialog. "Unable to open 'file.html#anchor' Cancel/Create File"
With this fix, you will either open file.html if it exists, or get a "Unable to open 'file.html' Cancel/Create File" dialog.