Skip to content

Adding mgmt libraries for Go + changing matcher logic for Go #191036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lramos15 merged 6 commits into from
Oct 12, 2023
Merged

Adding mgmt libraries for Go + changing matcher logic for Go #191036

lramos15 merged 6 commits into from
Oct 12, 2023

Conversation

@sandeep-sen
Copy link
Member

@sandeep-sen sandeep-sen commented Aug 22, 2023

  • Added management libraries for Go in the tags.
  • Added all management libraries for Go in the GDPR fragment.
  • Updated new Go libraries azdatalake, azingest and azopenai
  • Updated the package name to tag matcher for Go to use startsWith instead of absolute match

@sbatten sbatten assigned lramos15 and unassigned sbatten Aug 29, 2023
@lramos15 lramos15 added this to the September 2023 milestone Aug 29, 2023
@lramos15 lramos15 added telemetry Telemetry system issues and removed triage-needed labels Sep 25, 2023
@lramos15 lramos15 requested a review from isidorn September 26, 2023 18:23
@lramos15 lramos15 modified the milestones: September 2023, October 2023 Sep 26, 2023
@sandeep-sen
Copy link
Member Author

sandeep-sen commented Sep 28, 2023

@isidorn @lramos15 I cannot merge as I don't have write access. Do I need to do anything else to merge?
Screenshot 2023-09-27 at 10 10 23 PM

@isidorn
Copy link
Collaborator

isidorn commented Sep 28, 2023

@sandeep-sen no. We will merge this some time next week. Thanks for understanding.

@cobey
Copy link
Contributor

cobey commented Oct 12, 2023

@isidorn what is the eta for getting this merged? thanks!

@lramos15 lramos15 merged commit 5b0ed15 into microsoft:main Oct 12, 2023
@lramos15
Copy link
Member

lramos15 commented Oct 12, 2023

@isidorn what is the eta for getting this merged? thanks!

Now? :)

meganrogge pushed a commit that referenced this pull request Oct 13, 2023
@sandeep-sen @meganrogge
Adding mgmt libraries for Go + changing matcher logic for Go (#191036)
557fd3b 
* Adding management libraires for Go and upading matcher to startswith

* Corrected tag concat logic for Go
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@sandeep-sen @Alex0007
Adding mgmt libraries for Go + changing matcher logic for Go (microso…
fc061be 
…ft#191036)

* Adding management libraires for Go and upading matcher to startswith

* Corrected tag concat logic for Go
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@isidorn isidorn isidorn approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@lramos15 lramos15

Labels

telemetry Telemetry system issues

Projects

None yet

Milestone

October 2023

Development

Successfully merging this pull request may close these issues.

6 participants

@sandeep-sen @isidorn @cobey @lramos15 @sbatten @vscodenpa