Windows ARM64 builds have non-native ripgrep bundled

[tmm1]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.96.2
• OS Version: Windows ARM64

Steps to Reproduce:

1. Install vscode on Windows ARM64 machine
2. Observe that bundled ripgrep rg is not for arm64

& 'C:\Program Files\Git\usr\bin\file.exe' 'C:\Users\tmm1\AppData\Local\Programs\Microsoft VS Code\resources\app\node_modules\@vscode\ripgrep\bin\rg.exe'

C:\Users\tmm1\AppData\Local\Programs\Microsoft VS Code\resources\app\node_modules\@vscode\ripgrep\bin\rg.exe: PE32 executable (console) Intel 80386, for MS Windows, 4 sections

note the Intel 80386

cc microsoft/vscode-ripgrep#63

[deepak1556]

Was this issue identified because of perf issue in search widget, I believe the intel binary would have been translated and search would have worked today.

I think there is scope for improvement towards the root cause, we have CI check for macOS to ensure correct arch binaries are packaged https://github.com/microsoft/vscode/blob/main/build/darwin/verify-macho.ts. We should have something similar for windows and linux pipeline as well.

[tmm1]

Correct, the intel binary is translated and works. There are probably NEON and other optimizations being left on the table, although I'm not sure those are enabled in the ripgrep-prebuilt binaries.

I found this through manual audit of the build process and resulting binaries.