Include type name in Assumes.Null/NotNull failures#216
Merged
AArnott merged 2 commits intomicrosoft:mainfrom Oct 10, 2023
Merged
Include type name in Assumes.Null/NotNull failures#216AArnott merged 2 commits intomicrosoft:mainfrom
AArnott merged 2 commits intomicrosoft:mainfrom
Conversation
Recently I've seen a few errors from customers with error text "value is null" (the caller's expression), which isn't particularly helpful. This change attempts to include the name of the type in the message, which will help with diagnosis in many cases. With this change the message would read something like "Unexpected null value of type 'String'.". I've attempted to preserve the inlineability and tiny code size of the original methods by moving the formatting into a separate method. That method is generic (to avoid the caller having code to produce a type name) which could increase generated code size, however I wouldn't expect that to be a huge concern. It's worth calling out for review though.
Member
Author
|
A motivating example for this change is https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1880988 |
AArnott
requested changes
Sep 15, 2023
Member
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
I like it. Just a test change please.
This ensures tests run correctly, regardless of the environment's culture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I've seen a few errors from customers with error text "value is null" (the caller's expression), which isn't particularly helpful. This change attempts to include the name of the type in the message, which will help with diagnosis in many cases. With this change the message would read something like "Unexpected null value of type 'String'.".
I've attempted to preserve the inlineability and tiny code size of the original methods by moving the formatting into a separate method. That method is generic (to avoid the caller having code to produce a type name) which could increase generated code size, however I wouldn't expect that to be a huge concern. It's worth calling out for review though.