Skip to content

Handle spaces in GlobalSection definition. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erarndt merged 1 commit into from
Feb 21, 2025
Merged

Handle spaces in GlobalSection definition. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...crosoft.VisualStudio.SolutionPersistence/Serializer/SlnV12/SlnFileV12Serializer.Reader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ private bool ReadLine(out StringTokenizer lineScanner)
// So that is valid: ProjectSection ((( ))XXX===(())preProect
// We have to keep that behaviour, only slight difference will allow space in adition to tab at the end of name
// With all wierd syntaxes old will accepet, it will not accept ProjectSection( Foo ) (but will do ) ProjectSection( Foo) ...
StringSpan sectionName = tokenizer.NextToken(SlnConstants.SectionSeparators).Trim();
StringSpan sectionName = tokenizer.NextToken(SlnConstants.SectionSeparators2).Trim();
this.SolutionAssert(!sectionName.IsEmpty, Errors.MissingSectionName);
StringSpan sectionScopeStr = tokenizer.NextToken(SlnConstants.SectionSeparators).Trim();
this.SolutionAssert(TryParseScope(sectionScopeStr, isSolution, out PropertiesScope scope), Errors.InvalidScope);
Expand Down
3 changes: 3 additions & 0 deletions test/Microsoft.VisualStudio.SolutionPersistence.Tests/SlnAssets/SampleMany.sln.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ Global
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {210A5C78-8B93-42DA-8FB9-A667D3B01618}
EndGlobalSection
GlobalSection(DevPartner Solution Properties) = postSolution
SharedCPS\SharedCPS.vcxitems*{919107bb-2e8e-4dbb-ac5d-36ff8a211ffc}*SharedItemsImports = 9
EndGlobalSection
GlobalSection(SharedMSBuildProjectFiles) = preSolution
CSharpShared\CSharpShared.projitems*{51cc7781-a8d3-4c60-8065-f3ceedba8032}*SharedItemsImports = 13
SharedCPS\SharedCPS.vcxitems*{919107bb-2e8e-4dbb-ac5d-36ff8a211ffc}*SharedItemsImports = 9
Expand Down
3 changes: 3 additions & 0 deletions test/Microsoft.VisualStudio.SolutionPersistence.Tests/SlnAssets/SampleMany.slnx.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,7 @@
</Project>
</Folder>
<Project Path="TestProjectRoot/TestProjectRoot.csproj" />
<Properties Name="DevPartner Solution Properties" Scope="PostLoad">
<Property Name="SharedCPS\SharedCPS.vcxitems*{919107bb-2e8e-4dbb-ac5d-36ff8a211ffc}*SharedItemsImports" Value="9" />
</Properties>
</Solution>
1 change: 1 addition & 0 deletions version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "1.0",
"versionHeightOffset": "10",
"publicReleaseRefSpec": [
"^refs/heads/main$",
"^refs/heads/v\\d+(?:\\.\\d+)?$"
Expand Down