Fix handling of nested solution folders with same name.#75
Merged
richardstanton merged 1 commit intomainfrom Nov 18, 2024
Merged
Fix handling of nested solution folders with same name.#75richardstanton merged 1 commit intomainfrom
richardstanton merged 1 commit intomainfrom
Conversation
Erarndt
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing .sln files solution, folders are added to the model temporarily and then reparented. If there were multiple folders with the same name they would generate the same initial default id. When the actual id was assigned, it would remove the original one from the solutionItemsById lookup table, even if it was for a different folder. This would result in an error saving the file.
In addition, when the folders were reparented the default id state needed to be reevaluated.