Don't report error reading invalid project type guid in .sln files.#104
Merged
richardstanton merged 1 commit intomainfrom Feb 28, 2025
Merged
Don't report error reading invalid project type guid in .sln files.#104richardstanton merged 1 commit intomainfrom
richardstanton merged 1 commit intomainfrom
Conversation
ttstanley
reviewed
Feb 28, 2025
| if (!Guid.TryParse(projectType.ToString(), out Guid projectTypeId)) | ||
| { | ||
| projectTypeId = Guid.Empty; | ||
| this.tarnished = true; |
Contributor
There was a problem hiding this comment.
what exactly does marking it as tarnished do. Is there other functionality that is hidden behind the tarnished flag or is it mainly for logging?
Member
Author
There was a problem hiding this comment.
It indicates that a property was missing and when loaded by a designer like VS it marks the file as modified, so it gets resaved. The sln parser is very forgiving of reading with different errors. We don't rely on this when parsing slnx as the parser is much stricter.
ttstanley
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a behavior change between previous MSBuild and VS behavior. This serializer should not report an error if the project type is not a guid.