refactors server sent event handling in workbench-app to fix excessive reconnects; removes old workflows and interact ux #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rabach/semanticworkbench into brkrabac/async-dialog-actions
…orkbench into workflow-lite
…into brkrabac/event-source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elevates handling of SSE to route level component and adds hooks for adding/removing listeners from any child component without having to pass through props. Adds more logging as there was a swallowed error transforming events that was triggering retries even after new design - going forward, it'll be more obvious if there is an error causing this - or if there are 400/500 errors coming from the service.
Instead of updating the old workflows & interact UX components, I went ahead and removed them since they are no longer needed.