Skip to content

Conversation

@SunsetWolf
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Mar 15, 2023
@SunsetWolf
Copy link
Collaborator Author

For the changes in the recorder.py file, I think it is better to raise ValueError because self._artifact_uri is defined during initialization; if self._artifact_uri is not defined, it is more appropriate to raise AttributeError.

@you-n-g you-n-g merged commit 0e8bfcb into microsoft:main Mar 17, 2023
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix_pylint_w0719

* remove_fixme
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix_pylint_w0719

* remove_fixme
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix_pylint_w0719

* remove_fixme
@you-n-g you-n-g added maintenance improving code readability and maintainability and removed waiting for triage Cannot auto-triage, wait for triage. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance improving code readability and maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants