fix subprocess.check_output bug #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for triage
you-n-g
reviewed
Jan 6, 2023
qlib/workflow/recorder.py
Outdated
| ("git diff", "code_diff.txt"), | ||
| ("git status", "code_status.txt"), | ||
| ("git diff --cached", "code_cached.txt"), | ||
| (f"cd {str(root_path)} && git diff", "code_diff.txt"), |
Collaborator
There was a problem hiding this comment.
The feature is not designed for logging the uncommitted_code of Qlib
you-n-g
reviewed
Jan 6, 2023
| out = subprocess.check_output(cmd, shell=True) | ||
| self.client.log_text(self.id, out.decode(), fname) # this behaves same as above | ||
| except subprocess.CalledProcessError: | ||
| logger.info(f"Fail to log the uncommitted code of $CWD when run `{cmd}`") |
Collaborator
There was a problem hiding this comment.
logger.info(f"Fail to log the uncommitted code of $CWD({os.getpwd()}) when run {cmd}")
This was referenced Jan 6, 2023
you-n-g
added
enhancement
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix_check_output_bug * change_log_info * recover_feature
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix_check_output_bug * change_log_info * recover_feature
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix_check_output_bug * change_log_info * recover_feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes