Skip to content

The limit threshold in Taiwan stock market is also 10%. #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
you-n-g merged 2 commits into from
Dec 12, 2022
Merged

The limit threshold in Taiwan stock market is also 10%. #1391

you-n-g merged 2 commits into from
Dec 12, 2022

Conversation

@ChiahungTai
Copy link
Collaborator

@ChiahungTai ChiahungTai commented Dec 12, 2022

Description

A simple check for limit threshold in TW exchange.

Motivation and Context

The limit threshold in Taiwan stock market is also 10%.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ChiahungTai ChiahungTai requested a review from you-n-g December 12, 2022 01:34
@you-n-g you-n-g merged commit cbd69fb into microsoft:main Dec 12, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Dec 12, 2022

Thanks. It looks great :)

@ChiahungTai ChiahungTai deleted the limit_check branch December 13, 2022 00:36
@you-n-g you-n-g added the enhancement New feature or request label Jan 29, 2023
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
The limit threshold in Taiwan stock market is also 10%. (microsoft#1391)
31e8b01 
* The limit threshold in Taiwan stock market is also 10%.

* Warning limit_threshold when it is None.
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
The limit threshold in Taiwan stock market is also 10%. (microsoft#1391)
1076932 
* The limit threshold in Taiwan stock market is also 10%.

* Warning limit_threshold when it is None.
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai @qianyun210603
The limit threshold in Taiwan stock market is also 10%. (microsoft#1391)
4e8addc 
* The limit threshold in Taiwan stock market is also 10%.

* Warning limit_threshold when it is None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@you-n-g you-n-g Awaiting requested review from you-n-g

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChiahungTai @you-n-g