Skip to content

Conversation

@wan9c9
Copy link
Contributor

@wan9c9 wan9c9 commented Mar 24, 2022

update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file.

Description

In current workflow, the experiment manager uri will be overridden by the default in cli.py. This update allows the user to specify the uri.

Also, one can specify the experiment_name in yaml file.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • [x ] Add new feature
  • Update documentation

update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file.
@SunsetWolf
Copy link
Collaborator

Hi, thank you for submitting PR, now, your PR didn't pass the CI test, I think to solve this problem, you can try to use black formatting code.

@wan9c9
Copy link
Contributor Author

wan9c9 commented Mar 28, 2022

Hi @SunsetWolf ,

Thanks for the suggestions. I tried to use black on cli.py. But the checks were still not successful. Can you please look into it and let me know what was wrong?

Thanks!

@SunsetWolf
Copy link
Collaborator

Hi @SunsetWolf ,

Thanks for the suggestions. I tried to use black on cli.py. But the checks were still not successful. Can you please look into it and let me know what was wrong?

Thanks!

To solve this problem, we added the pre-commit hook to qlib, and you can check the fourth article of the developer documentation to learn how to use it.

@you-n-g
Copy link
Collaborator

you-n-g commented Apr 1, 2022

Besides, you can checkout the error information here
image

@you-n-g you-n-g merged commit 08fd1d3 into microsoft:main Apr 12, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Apr 12, 2022

It looks great!
Thanks :)

@you-n-g you-n-g added the bug Something isn't working label Apr 24, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* update cli.py

update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file.

* black cli.py

* Resolving pre-commit-hook changes
you-n-g pushed a commit to you-n-g/qlib that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants