feat(dragAndDrop): page.dragAndDrop#6910
Merged
JoelEinbinder merged 3 commits intomicrosoft:masterfrom Jul 19, 2021
Merged
Conversation
Contributor
|
@JoelEinbinder whats the status on this? |
Contributor
Author
|
Needs a discussion of the api. |
mxschmitt
reviewed
Jul 12, 2021
types/types.d.ts
Outdated
| * @param selector2 | ||
| * @param options | ||
| */ | ||
| dragAndDrop(selector1: string, selector2: string, options?: { |
Contributor
There was a problem hiding this comment.
Let's call it maybe source and target everywhere? So it also reflects nicer in auto completion. Some editors show the parameter name in the parameter list and selector1 and selector2 might be not idiomatic.
mxschmitt
approved these changes
Jul 19, 2021
pavelfeldman
approved these changes
Jul 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for the chromium specific changes to land.
Proposed api:
page.dragAndDrop(selector1, selector2, options)Also exists on the frame.
Assuming people like the api I will go write some docs.
#7562