-
Notifications
You must be signed in to change notification settings - Fork 29
Add container logic for matrix builds and enable containers for others #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2022
Merged
os-d
approved these changes
Dec 5, 2022
apop5
approved these changes
Dec 5, 2022
makubacki
reviewed
Dec 5, 2022
makubacki
reviewed
Dec 5, 2022
kuqin12
approved these changes
Dec 6, 2022
cfernald
added a commit
to microsoft/mu_basecore
that referenced
this pull request
Dec 6, 2022
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
cfernald
added a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Dec 6, 2022
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
cfernald
added a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
Dec 6, 2022
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
cfernald
added a commit
to microsoft/mu_silicon_intel_tiano
that referenced
this pull request
Dec 6, 2022
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_intel_tiano
that referenced
this pull request
May 11, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_intel_tiano
that referenced
this pull request
May 11, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
May 12, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
May 13, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
May 13, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
May 13, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_plus
that referenced
this pull request
May 14, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_plus
that referenced
this pull request
May 14, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
May 15, 2023
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Oct 17, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Oct 18, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Oct 18, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Oct 20, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Oct 23, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_tiano_plus
that referenced
this pull request
Oct 23, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_tiano_plus
that referenced
this pull request
Oct 23, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_intel_tiano
that referenced
this pull request
Oct 24, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_intel_tiano
that referenced
this pull request
Oct 24, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
Oct 25, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Oct 26, 2023
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Dec 16, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Dec 18, 2023
## Description Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on test pipeline with mu_devops changes made locally ## Integration Instructions N/A
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
Dec 19, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_silicon_arm_tiano
that referenced
this pull request
Dec 19, 2023
Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [x] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally his is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Dec 20, 2023
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Aug 2, 2024
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Aug 2, 2024
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Aug 2, 2024
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Jan 10, 2025
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
apop5
pushed a commit
to microsoft/mu_common_intel_min_platform
that referenced
this pull request
Feb 11, 2025
Updates this repo to use mu_devops for Azure Pipeline definitions. In order to centralize definitions and avoid build churn in individual Mu repos, some changes are made to allow build administrators to quickly adjust settings: - Toolchain, VM image, and architecture are controlled by build administrators through centralized variable groups - CI triggers, CI schedules, and PR triggers are controlled by build administrators within the individual pipeline UI settings - [ ] Breaking change? - Will this change break pre-existing builds or functionality without action being taken? **No** Verified in test pipelines. N/A - No developer integration required Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Add logic for container build to Matrix-Build-Job.yml (#80) Changes the matrix build job to be able to take input for the container image used in the generic mu_devops file generated. Will be used by: microsoft/mu_devops#59 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? Tested on test pipeline with mu_devops changes made locally N/A .azurepipelines: Add support for new artifacts_identifier param (#104) A new identifier can be used to identify published artifacts (as of mu_devops 2.0.0 release). This change passes the packages and targets being built to clarify artifact names. The default value for the identifier is "Artifacts" so that is what is being used at the moment. For example, build logs are published under `"Logs Artifacts"`. After this change, the identifier will be `"Logs <packages> <targets>"`. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [x] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Verified pipeline artifacts are named as expected. This is considered a "breaking change" because artifacts are accessible via ADO APIs and can be identified by the artifact name. While it is unlikely any process is consuming these artifacts based on name, if they are, they will need to use the new artifact naming convention introduced in this change. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
microsoft/mu_basecore#199
microsoft/mu_common_intel_min_platform#80
microsoft/mu_plus#118
microsoft/mu_silicon_arm_tiano#32
microsoft/mu_silicon_intel_tiano#29
microsoft/mu_tiano_plus#67