Steps/PrGate.yml: Add pkg_count condition to build steps #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a condition to build steps to only execute if pkg_count is greater than zero. The pkg_count is set to a default value of 1. Stuart PR Eval might set it to zero if that is used and no packages need to be built. When it does so, it also clears the package name variable. So not only is the a performance optimization, it is required if Stuart PR Eval runs and determines no packages need to be built. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
commented
Sep 1, 2022
cfernald
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a condition to build steps to only execute if pkg_count is
greater than zero. The pkg_count is set to a default value of 1.
Stuart PR Eval might set it to zero if that is used and no packages
need to be built. When it does so, it also clears the package name
variable. So not only is the a performance optimization, it is
required if Stuart PR Eval runs and determines no packages need
to be built.
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com